[
https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martijn van Groningen updated LUCENE-6959:
------------------------------------------
Attachment: LUCENE_6959.patch
I've updated the patch. Thanks for reviewing!
bq. should it take the childQuery into account for equals/hashcode?
Oops, I forgot to add that back when removing `origChildQuery `.
bq. it looks buggy to me that we do not convert parentDocId to
parentDocId-context.docBase in the scorer?
Good catch. I didn't catch this in the initially, but after running the
provided test in the patch a 100 times it did fail, because the `parentDocId`
wasn't converted.
bq. you use ConstantScoreWeight but then return a Scorer that actually scores,
you should extend Weight directly instead.
Good point, I've changed that.
bq. Let's remove the "we"?
Done.
> Remove ToParentBlockJoinCollector
> ---------------------------------
>
> Key: LUCENE-6959
> URL: https://issues.apache.org/jira/browse/LUCENE-6959
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Minor
> Attachments: LUCENE_6959.patch, LUCENE_6959.patch, LUCENE_6959.patch,
> LUCENE_6959.patch, LUCENE-6959.patch
>
>
> This collector uses the getWeight() and getChildren() methods from the passed
> in Scorer, which are not always available (eg. disjunctions expose fake
> scorers) hence the need for a dedicated IndexSearcher
> (ToParentBlockJoinIndexSearcher). Given that this is the only collector in
> this case, I would like to remove it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
