[ 
https://issues.apache.org/jira/browse/SOLR-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856094#comment-15856094
 ] 

Steve Rowe commented on SOLR-6246:
----------------------------------

[~jefferyyuan], you yourself tested 6.4.1 and found that the fixes included in 
that release fixed your problem.  Quoting the CHANGES.txt entry for this issue:

bq. Added tests to check that the changes in LUCENE-7564 and LUCENE-7670 enable 
AnalyzingInfixSuggester and BlendedInfixSuggester to play nicely with core 
reload.

LUCENE-7564 and LUCENE-7670 contain the fixes for the problem identified in 
this issue, and they were included in Lucene/Solr 6.4.1.

This issue contains tests that confirm the fix in the Solr context, and it 
wasn't ready until after the 6.4.1 release candidate voting was already 
underway, so couldn't be included.  

Here's what I included in the Solr 6.4.1 release announcement:

bq. AnalyzingInfixSuggester/BlendedInfixSuggester now work with core reload

> Core fails to reload when AnalyzingInfixSuggester is used as a Suggester
> ------------------------------------------------------------------------
>
>                 Key: SOLR-6246
>                 URL: https://issues.apache.org/jira/browse/SOLR-6246
>             Project: Solr
>          Issue Type: Sub-task
>          Components: SearchComponents - other
>    Affects Versions: 4.8, 4.8.1, 4.9, 5.0, 5.1, 5.2, 5.3, 5.4
>            Reporter: Varun Thacker
>            Assignee: Steve Rowe
>             Fix For: 6.5, master (7.0)
>
>         Attachments: SOLR-6246.patch, SOLR-6246.patch, SOLR-6246-test.patch, 
> SOLR-6246-test.patch, SOLR-6246-test.patch, SOLR-6246-test.patch
>
>
> LUCENE-5477 - added near-real-time suggest building to 
> AnalyzingInfixSuggester. One of the changes that went in was a writer is 
> persisted now to support real time updates via the add() and update() methods.
> When we call Solr's reload command, a new instance of AnalyzingInfixSuggester 
> is created. When trying to create a new writer on the same Directory a lock 
> cannot be obtained and Solr fails to reload the core.
> Also when AnalyzingInfixLookupFactory throws a RuntimeException we should 
> pass along the original message.
> I am not sure what should be the approach to fix it. Should we have a 
> reloadHook where we close the writer?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to