[
https://issues.apache.org/jira/browse/LUCENE-7681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856451#comment-15856451
]
Adrien Grand commented on LUCENE-7681:
--------------------------------------
+1 for using the new iterator API!
Is the norm really computed lazily? I see a call to {{getNormDocValues}} in
{{freeze()}} which makes me think it is computed up-front.
Also I think the {{advanceExact}} impls do not honor the contract that docId()
returns {{target}} after {{advanceExact(target)}} has been called, regardless
of whether the document had a value for that doc (however, since target needs
to be a valid docID, it may only be 0 in the case of MemoryIndex).
> Remove LegacyDocValues implementations from MemoryIndex
> -------------------------------------------------------
>
> Key: LUCENE-7681
> URL: https://issues.apache.org/jira/browse/LUCENE-7681
> Project: Lucene - Core
> Issue Type: Improvement
> Affects Versions: master (7.0)
> Reporter: Alan Woodward
> Assignee: Alan Woodward
> Priority: Minor
> Attachments: LUCENE-7681.patch
>
>
> MemoryIndex in master is using the LegacyDocValue wrappers. We should
> replace these with plain 7.0-style iterators instead.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
