[
https://issues.apache.org/jira/browse/LUCENE-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856450#comment-15856450
]
David Smiley commented on LUCENE-7680:
--------------------------------------
The hard coded rules here (and others) concern me. If I override
{{shouldCache}} I should hopefully be able to have my own different rules. I
see that this method invokes a {{frequency(...)}} method and
{{minFrequencyToCache(...)}} pair of methods; the former is package level. It
should be protected? Granted I could implement minFrequencyToCache and return
{{Integer.MAX_VALUE}}.
Curious; did you consider marking TermFilter as "cheap"?
> Never cache term filters
> ------------------------
>
> Key: LUCENE-7680
> URL: https://issues.apache.org/jira/browse/LUCENE-7680
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Priority: Minor
> Attachments: LUCENE-7680.patch
>
>
> Currently we just require term filters to be used a lot in order to cache
> them. Maybe instead we should look into never caching them. This should not
> hurt performance since term filters are plenty fast, and would make other
> filters more likely to be cached since we would not "pollute" the history
> with filters that are not worth caching.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
