[
https://issues.apache.org/jira/browse/SOLR-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862241#comment-15862241
]
David Smiley commented on SOLR-9987:
------------------------------------
Wow you did a lot of work for this! Thanks for doing this work.
As I skimmed through with curiosity, one thing caught my eye:
{code}
+// We should do this, but mincount=0 is currently the default
+// if (ft.isPointField() && mincount <= 0) {
+// throw new SolrException(ErrorCode.BAD_REQUEST,
FacetParams.FACET_MINCOUNT + " <= 0 is not supported on point types");
+// }
{code}
Judging from this and nearby code changes, if minCount is 0 then you make it 1
instead (for PointFields only); is this right? This seems wrong to me. I
suspect we all agree that the default of 0 is unfortunate but ignoring it and
pretending it's not in certain cases but not others seems wrong. Instead, I
propose that we make the default '1' for 7.0. Obviously such a change would be
in another issue.
> Implement support for multi-valued DocValues in PointFields
> -----------------------------------------------------------
>
> Key: SOLR-9987
> URL: https://issues.apache.org/jira/browse/SOLR-9987
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Tomás Fernández Löbbe
> Assignee: Tomás Fernández Löbbe
> Attachments: SOLR-9987.patch, SOLR-9987.patch
>
>
> This is not currently supported, and since PointFields can't use FieldCache,
> faceting, stats, etc is not supported on multi-valued point fields. Followup
> task of SOLR-8396
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
