[ https://issues.apache.org/jira/browse/LUCENE-3113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034846#comment-13034846 ]
Robert Muir commented on LUCENE-3113: ------------------------------------- Uwe, I think i'll open a followup issue to clean up the code about PrefixAndSuffixAwareTF. I don't like how tricky it is. > fix analyzer bugs found by MockTokenizer > ---------------------------------------- > > Key: LUCENE-3113 > URL: https://issues.apache.org/jira/browse/LUCENE-3113 > Project: Lucene - Java > Issue Type: Bug > Components: modules/analysis > Reporter: Robert Muir > Fix For: 3.2, 4.0 > > Attachments: LUCENE-3113.patch, LUCENE-3113.patch > > > In LUCENE-3064, we beefed up MockTokenizer with assertions, and I've switched > over the analysis tests to use MockTokenizer for better coverage. > However, this found a few bugs (one of which is LUCENE-3106): > * incrementToken() after it returns false in CommonGramsQueryFilter, > HyphenatedWordsFilter, ShingleFilter, SynonymFilter > * missing end() implementation for PrefixAwareTokenFilter > * double reset() in QueryAutoStopWordAnalyzer and ReusableAnalyzerBase > * missing correctOffset()s in MockTokenizer itself. > I think it would be nice to just fix all the bugs on one issue... I've fixed > everything except Shingle and Synonym -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org