[ 
https://issues.apache.org/jira/browse/SOLR-10153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15873056#comment-15873056
 ] 

Amrit Sarkar edited comment on SOLR-10153 at 2/19/17 9:28 AM:
--------------------------------------------------------------

SOLR-10153.patch uploaded which incorporates CustomSeparatorBreakIterator in 
UnifiedSolrHighlighter.

- added a new request param option to specify which separator char to use. 
*customSeparatorChar*.
- changed UnifiedSolrHighlighter.getBreakIterator to check 
HighlightParams.BS_TYPE first.
- if type=='CUSTOM', look for the new separator param, in getBreakIterator 
validate it's a single char & skip locale parsing.
- 'WHOLE' option moved from parseBreakIterator to getBreakIterator, as it 
doesn't depend on locale.

Changes made in:
* HighlightParams.java
* UnifiedSolrHighlighter.java
* test cases added in TestUnifiedSolrHighlighter


was (Author: sarkaramr...@gmail.com):
SOLR-10153.patch uploaded which incorporates CustomSeparatorBreakIterator in 
UnifiedSolrHighlighter.

- added a new request param option to specify which separator char to use. 
*customSeparatorChar*.
- changed UnifiedSolrHighlighter.getBreakIterator to check 
HighlightParams.BS_TYPE first.
- if type=='CUSTOM', look for the new separator param, in getBreakIterator 
validate it's a single char, & skip locale parsing.
- 'WHOLE' option moved from parseBreakIterator to getBreakIterator, as it 
doesn't depend on locale.

Changes made in:
* HighlightParams.java
* UnifiedSolrHighlighter.java
* test cases added in TestUnifiedSolrHighlighter

> UnifiedSolrHighlighter support for CustomSeparatorBreakIterator (LUCENE-6485)
> -----------------------------------------------------------------------------
>
>                 Key: SOLR-10153
>                 URL: https://issues.apache.org/jira/browse/SOLR-10153
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: highlighter
>            Reporter: Amrit Sarkar
>         Attachments: SOLR-10153.patch
>
>
> Lucene 5.3 added a CustomSeparatorBreakIterator (see LUCENE-6485)
> UnifiedSolrHighlighter should support *CustomSeparatorBreakIterator* along 
> with existing ones, WholeBreakIterator etc.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to