[
https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035508#comment-13035508
]
Michael McCandless commented on LUCENE-2883:
--------------------------------------------
Thanks Chris! The patch applies cleanly for me (after running the svn
commands) and everything compiles.
I think the patch is a great start, ie, we will need the low level
infra used by FQs in the module.
bq. MutableValue & MutableFloatValue are used in the FunctionQuery code so I've
pulled them into the module too. Should all the other Mutable*Value classes
come too? Should they go into some other module?
I think we should move Mutable* over? Grouping module will need all
of these, I think? (Ie if we want to allow users to group by
arbitrary typed field).
bq. What to return in ValueSource#getSortField which currently returns a
SortField which implements SolrSortField. This is currently commented out so we
can determine what best to do. Having this commented out breaks the Solr tests.
Hmm good question. This looks to be related to sorting by FQ
(SOLR-1297) because some FQs need to be weighted. Not sure what to do
here yet... which FQs in particular require this?
bq. Many of the ValueSources and DocValues in Solr could be moved to the
module, but not all of them. Some have dependencies on Solr dependencies / Solr
core code.
I think apply 90/10 rule here? Start with the easy-to-move queries?
We don't need initial go to be perfect... progress not perfection.
bq. Lucene core's FunctionQuery stuff needs to be removed.
Do you have a sense of whether Solr's FQs are a superset of Lucene's?
Ie, is there anything Lucene's FQs can do that Solr's can't?
Probably, as a separate issue, we should also move contrib/queries ->
modules/queries. And I think the cool nested queries (LUCENE-2454)
would also go into this module...
> Consolidate Solr & Lucene FunctionQuery into modules
> -----------------------------------------------------
>
> Key: LUCENE-2883
> URL: https://issues.apache.org/jira/browse/LUCENE-2883
> Project: Lucene - Java
> Issue Type: Task
> Components: core/search
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Labels: gsoc2011, lucene-gsoc-11, mentor
> Fix For: 4.0
>
> Attachments: LUCENE-2883.patch
>
>
> Spin-off from the [dev list |
> http://www.mail-archive.com/dev@lucene.apache.org/msg13261.html]
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
