[
https://issues.apache.org/jira/browse/SOLR-2524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035526#comment-13035526
]
Michael McCandless commented on SOLR-2524:
------------------------------------------
Awesome, that was fast!
Maybe rename group.cache.maxSize -> .maxSizeMB? (So it's clear what the units
are).
Should we default group.cache to true? (It's false now?).
When you get the top groups from collector2, should you pass in offset instead
of 0? (Hmm -- maybe groupOffset? It seems like you're using offset for both
the first & second phase collectors? Maybe I'm confused...).
bq. Computed DocSet (for facetComponent and StatsComponent) is based the
ungrouped result.
This matches how Solr does grouping on trunk right?
> Adding grouping to Solr 3x
> --------------------------
>
> Key: SOLR-2524
> URL: https://issues.apache.org/jira/browse/SOLR-2524
> Project: Solr
> Issue Type: New Feature
> Affects Versions: 3.2
> Reporter: Martijn van Groningen
> Attachments: SOLR-2524.patch
>
>
> Grouping was recently added to Lucene 3x. See LUCENE-1421 for more
> information.
> I think it would be nice if we expose this functionality also to the Solr
> users that are bound to a 3.x version.
> The grouping feature added to Lucene is currently a subset of the
> functionality that Solr 4.0-trunk offers. Mainly it doesn't support grouping
> by function / query.
> The work involved getting the grouping contrib to work on Solr 3x is
> acceptable. I have it more or less running here. It supports the response
> format and request parameters (expect: group.query and group.func) described
> in the FieldCollapse page on the Solr wiki.
> I think it would be great if this is included in the Solr 3.2 release. Many
> people are using grouping as patch now and this would help them a lot. Any
> thoughts?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
