[ https://issues.apache.org/jira/browse/SOLR-10153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890402#comment-15890402 ]
David Smiley commented on SOLR-10153: ------------------------------------- It's okay; I think _all_ software developers struggle with naming :-). Goes with the job. Thanks again for the contribution. Now that I think about naming again... hmmm, maybe a more useful/memorable Solr parameter for this might be {{hl.bs.separatorChar}} ? I understand why you chose the name you did since it's based on a class name but users don't know/char about that. The "hl.bs" namespaces this param as related to the other break iterator related params, which this is. "Custom" is superfluous; we provide it directly via a parameter. Hmmm; do we even need {{hl.bs.type==CUSTOM}} if the user sets {{hl.bs.separatorChar}}? I guess it should be set so that there is consistency in mapping the type to an algorithm. Though maybe use the value {{SEPARATOR}}? And maybe just name this {{hl.bs.separator}} to open the door for possibly using an arbitrary length string in the future? Thus I propose {{hl.bs.type=SEPARATOR}} with e.g. {{hl.bs.separator=|}} > UnifiedSolrHighlighter support for CustomSeparatorBreakIterator (LUCENE-6485) > ----------------------------------------------------------------------------- > > Key: SOLR-10153 > URL: https://issues.apache.org/jira/browse/SOLR-10153 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: highlighter > Reporter: Amrit Sarkar > Attachments: SOLR-10153.patch, SOLR-10153.patch, > SOLR_10153_UH_and_PH_hl_customSeparatorChar.patch > > > Lucene 5.3 added a CustomSeparatorBreakIterator (see LUCENE-6485) > UnifiedSolrHighlighter should support *CustomSeparatorBreakIterator* along > with existing ones, WholeBreakIterator etc. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org