[ https://issues.apache.org/jira/browse/SOLR-9401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15894241#comment-15894241 ]
Steve Rowe edited comment on SOLR-9401 at 3/3/17 12:25 PM: ----------------------------------------------------------- Noble's offline description of the latest patch: {quote} While testing I realized that the time consuming part of the test was creating a new public key. We may not need to do the retry if we precreate the key. Even on a fast machine it took almost 2 seconds. I've posted a new patch which undo all the new changes and create the public key in adavance. {quote} I beasted the latest patch for 300 iterations and there were no failures: +1 One small recommendation: move the creation of the key to be with test #4 - right now it's with test #3, even though its first and only use is in test #4. {code:java} 113: //test 3 . No user request . Request originated from Solr 114: PublicKey key = new CryptoKeys.RSAKeyPair().getPublicKey(); ... 128: /*test4 mock the restart of a node*/ ... 134: return called == 0 ? key : correctKey; {code} was (Author: steve_rowe): Noble's offline description of the latest patch: {quote} While testing I realized that the time consuming part of the test was creating a new public key. We may not need to do the retry if we precreate the key. Even on a fast machine it took almost 2 seconds. I've posted a new patch which undo all the new changes and create the public key in adavance. {quote} I beasted the latest patch for 300 iterations and there were no failures: +1 One small recommendation: move the creation of the key to be with test #4 - right now it's with test #3, even though its first and only use is in test #4. {code:java} 113: //test 3 . No user request . Request originated from Solr 114: PublicKey key = new CryptoKeys.RSAKeyPair().getPublicKey(); ... 128: /*test4 mock the restart of a node*/ 134: return called == 0 ? key : correctKey; {code} > TestPKIAuthenticationPlugin NPE > ------------------------------- > > Key: SOLR-9401 > URL: https://issues.apache.org/jira/browse/SOLR-9401 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Reporter: Steve Rowe > Assignee: Noble Paul > Fix For: 6.5, master (7.0) > > Attachments: SOLR-9401.patch, SOLR-9401.patch, SOLR-9401.patch, > SOLR-9401.patch > > > Failure from my Jenkins, doesn't reproduce for me (this is > {{tests-failures.txt}}): > {noformat} > 2> Creating dataDir: > /var/lib/jenkins/jobs/Lucene-Solr-tests-master/workspace/solr/build/solr-core/test/J7/temp/solr.security.TestPKIAuthenticationPlugi > n_7AC33B2240CB767D-001/init-core-data-001 > 2> 14521 INFO > (SUITE-TestPKIAuthenticationPlugin-seed#[7AC33B2240CB767D]-worker) [ ] > o.a.s.SolrTestCaseJ4 Randomized ssl (false) and clientAuth (fal > se) via: @org.apache.solr.util.RandomizeSSL(reason=, ssl=NaN, value=NaN, > clientAuth=NaN) > 2> 14540 INFO > (TEST-TestPKIAuthenticationPlugin.test-seed#[7AC33B2240CB767D]) [ ] > o.a.s.SolrTestCaseJ4 ###Starting test > 2> 15553 ERROR > (TEST-TestPKIAuthenticationPlugin.test-seed#[7AC33B2240CB767D]) [ ] > o.a.s.s.PKIAuthenticationPlugin No SolrAuth header present > 2> 15843 ERROR > (TEST-TestPKIAuthenticationPlugin.test-seed#[7AC33B2240CB767D]) [ ] > o.a.s.s.PKIAuthenticationPlugin Invalid key request timestamp: 9 , > received timestamp: 1470760833176 , TTL: 5000 > 2> 15843 INFO > (TEST-TestPKIAuthenticationPlugin.test-seed#[7AC33B2240CB767D]) [ ] > o.a.s.SolrTestCaseJ4 ###Ending test > 2> NOTE: download the large Jenkins line-docs file by running 'ant > get-jenkins-line-docs' in the lucene directory. > 2> NOTE: reproduce with: ant test -Dtestcase=TestPKIAuthenticationPlugin > -Dtests.method=test -Dtests.seed=7AC33B2240CB767D -Dtests.slow=true -Dtests.li > nedocsfile=/home/jenkins/lucene-data/enwiki.random.lines.txt > -Dtests.locale=cs -Dtests.timezone=Europe/Tirane -Dtests.asserts=true > -Dtests.file.encoding=U > TF-8 > [12:40:32.094] ERROR 1.35s J7 | TestPKIAuthenticationPlugin.test <<< > > Throwable #1: java.lang.NullPointerException > > at > __randomizedtesting.SeedInfo.seed([7AC33B2240CB767D:F29704F8EE371B85]:0) > > at > org.apache.solr.security.TestPKIAuthenticationPlugin.test(TestPKIAuthenticationPlugin.java:144) > [...] > 2> 15867 INFO > (SUITE-TestPKIAuthenticationPlugin-seed#[7AC33B2240CB767D]-worker) [ ] > o.a.s.SolrTestCaseJ4 ###deleteCore > 2> NOTE: leaving temporary files on disk at: > /var/lib/jenkins/jobs/Lucene-Solr-tests-master/workspace/solr/build/solr-core/test/J7/temp/solr.security.TestPKIAuthenticationPlugin_7AC33B2240CB767D-001 > 2> NOTE: test params are: codec=Asserting(Lucene62): {}, docValues:{}, > maxPointsInLeafNode=752, maxMBSortInHeap=5.390190554185364, > sim=RandomSimilarity(queryNorm=true): {}, locale=cs, timezone=Europe/Tirane > 2> NOTE: Linux 4.1.0-custom2-amd64 amd64/Oracle Corporation 1.8.0_77 > (64-bit)/cpus=16,threads=1,free=255922760,total=336592896 > 2> NOTE: All tests run in this JVM: [TestIndexingPerformance, > TestPKIAuthenticationPlugin] > {noformat} -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org