[ 
https://issues.apache.org/jira/browse/SOLR-10237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15901444#comment-15901444
 ] 

David Smiley commented on SOLR-10237:
-------------------------------------

bq. Maybe... I'm not totally sold. I think there are valid use cases for 
wanting to modify the returned list before adding it to the Document.

Remember Document is just a wrapper around an ArrayList.  A caller that wanted 
to manipulate the list could simply use a Document instance for a transient 
purpose; even re-using it by calling doc.clear().

bq. Not sure I follow, how would this refactor help?

It's not a necessity.  

> Poly-Fields should error if subfield has docValues=true
> -------------------------------------------------------
>
>                 Key: SOLR-10237
>                 URL: https://issues.apache.org/jira/browse/SOLR-10237
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Tomás Fernández Löbbe
>            Priority: Minor
>         Attachments: SOLR-10237.patch
>
>
> DocValues aren’t really supported in poly-fields at this point, but they 
> don’t complain if the schema definition of the subfield has docValues=true. 
> This leaves the index in an inconsistent state, since the SchemaField has 
> docValues=true but there are no DV for the field.
> Since this breaks compatibility, I think we should just emit a warning unless 
> the subfield is an instance of {{PointType}}. With 
> {{\[Int/Long/Float/Double/Date\]PointType}} subfields, this is particularly 
> important, since they use {{IndexOrDocValuesQuery}}, that would return 
> incorrect results.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to