[ https://issues.apache.org/jira/browse/LUCENE-7737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Smiley updated LUCENE-7737: --------------------------------- Component/s: modules/spatial-extras Hey; nice work Alan! You've put a lot of work into this. I suppose ValueSource is being phased out (or moved to Solr); which I welcome. Do we lose "explaination" for BBoxSimilarityValueSource.getValues? It's very very useful to see what the underlying computation is. nitpickt: SerializedDVStrategy.java declare the BytesRefBuilder field at the top of the inner class before the methods > Remove spatial-extras dependency on queries > ------------------------------------------- > > Key: LUCENE-7737 > URL: https://issues.apache.org/jira/browse/LUCENE-7737 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial-extras > Reporter: Alan Woodward > Priority: Minor > Attachments: LUCENE-7737.patch > > > The spatial-extras module uses ValueSources for a number of different > purposes, requiring a dependency on the queries module. I'd like to try > using core-only interfaces here instead, allowing us to remove the dependency -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org