[ 
https://issues.apache.org/jira/browse/LUCENE-7729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937061#comment-15937061
 ] 

Amrit Sarkar commented on LUCENE-7729:
--------------------------------------

Regarding,

bq. Just curious; is this feature driven by a search-app requirement or ...

This is follow-up of the conversation we had for SOLR-10153:
bq. David: .... Hmmm; do we even need hl.bs.type==CUSTOM if the user sets 
hl.bs.separatorChar? I guess it should be set so that there is consistency in 
mapping the type to an algorithm. Though maybe use the value SEPARATOR? And 
maybe just name this hl.bs.separator to open the door for possibly using an 
arbitrary length string in the future?

I observed the code and understood it will not require major refactoring to 
change the current implementation for arbitrary length string.

> Support for string type separator for CustomSeparatorBreakIterator
> ------------------------------------------------------------------
>
>                 Key: LUCENE-7729
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7729
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/highlighter
>            Reporter: Amrit Sarkar
>         Attachments: LUCENE-7729.patch, LUCENE-7729.patch
>
>
> LUCENE-6485: currently CustomSeparatorBreakIterator breaks the text when the 
> _char_ passed is found.
> Improved CustomSeparatorBreakIterator; as it now supports separator of string 
> type of arbitrary length.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to