[ https://issues.apache.org/jira/browse/SOLR-2533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037558#comment-13037558 ]
Chris Male commented on SOLR-2533: ---------------------------------- bq. So, this 'weighting' is more like Query.rewrite than Query.weight, right? bq. Except I wonder if we should rename "weight" to "rewrite" Yeah I totally agree. The fact that ValueSources use to weight inner Queries is actually an implementation detail and even then it does a rewrite too. I think for consistency with Query, we should go with rewrite. I'll regenerate the patch. > Improve API of ValueSource & FunctionQuery SortField weighting > -------------------------------------------------------------- > > Key: SOLR-2533 > URL: https://issues.apache.org/jira/browse/SOLR-2533 > Project: Solr > Issue Type: Improvement > Components: search > Reporter: Chris Male > Attachments: SOLR-2533.patch > > > Started from LUCENE-2883: Support for sorting by ValueSource and > FunctionQueries is done through ValueSource#getSort and the > ValueSourceSortField. In order to support VSs containing other Queries, its > necessary to allow the Querys to be weighted by an IndexSearcher. Currently > this is handled by having ValueSourceSortField implement SolrSortField. In > Solr's SolrIndexSearcher, SortFields implementing SolrSortField are then > weighted before the Sort is used. > Sorting by FunctionQuery and ValueSource are invaluable and will become > available to all Lucene users in LUCENE-2883. But in order to do so, we need > to remove the coupling of this functionality to Solr, and make it more > standard. > Any and all thoughts about how to do this are appreciated. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org