[
https://issues.apache.org/jira/browse/SOLR-10346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15949724#comment-15949724
]
Cassandra Targett edited comment on SOLR-10346 at 3/30/17 8:14 PM:
-------------------------------------------------------------------
I just committed some changes that remove {{topnav.yml}} and hardcoded the html
into {{topnav.html}}. This makes it easy to use the
{{site.solr-attributes.solr-javadocs}} variable in the liquid template and
considering how little we need to put there that seemed easiest. The YAML data
model really works best when you want the same look & feel with a different
menu, and that's not the case here.
I also hard-coded the "News" link to go to the Solr website's News page, and
changed what users see to "Solr News".
I modified {{_config.yml.template}} to disable feedback ({{feedback_disable:
true}}. I couldn't really think of where we'd want email to go, and they will
be able to comment on the pages. I have not yet removed the {{feedback.html}}
file, however, in case anyone disagrees.
Oh, and I removed the "Jekyll Resources" stuff entirely.
The commit is:
https://git1-us-west.apache.org/repos/asf?p=lucene-solr.git;a=commit;h=3b592f1be5f803c33fc170f6bf54b78e0597bef3
was (Author: ctargett):
I just committed some changes that remove {{topnav.yml}} and hardcoded the html
into {{topnav.html}}. This makes it easy to use the
{{site.solr-attributes.solr-javadocs}} variable in the liquid template and
considering how little we need to put there that seemed easiest. The YAML data
model really works best when you want the same look & feel with a different
menu, and that's not the case here.
I also hard-coded the "News" link to go to the Solr website's News page, and
changed what users see to "Solr News".
I modified {{_config.yml.template}} to disable feedback ({{feedback_disable:
true}}. I couldn't really think of where we'd want email to go, and they will
be able to comment on the pages. I have not yet removed the {{feedback.html}}
file, however, in case anyone disagrees.
The commit is:
https://git1-us-west.apache.org/repos/asf?p=lucene-solr.git;a=commit;h=3b592f1be5f803c33fc170f6bf54b78e0597bef3
> Clean up static page HTML top nav
> ---------------------------------
>
> Key: SOLR-10346
> URL: https://issues.apache.org/jira/browse/SOLR-10346
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: documentation
> Reporter: Cassandra Targett
> Attachments: SRG-top-nav-20170322.png, SRG-topnav-20170330.png
>
>
> For demo purposes, the top navigation bar for the HTML version of the Ref
> Guide includes some stuff we probably don't want in production. This should
> be cleaned up and finalized.
> I'll attach a screenshot of the current nav for reference. It currently has
> these sections:
> * Home link. This should be made dynamic to update automatically for each
> version the Guide applies to
> * News. Probably don't need this? Today it goes nowhere, but it could go to
> the News section of the Solr website.
> * Jekyll Resources. Links to stuff about Jekyll. We don't want this.
> * Solr Resources. Links to Javadocs, Source code and Community page of Solr
> website. Javadoc links should be dynamic.
> * Feedback. Javascript to open local Mail application to send an email.
> Currently goes to my apache.org address, which I don't want.
> * Search box. This can stay, and we can modify it to do whatever we want it
> to do when SOLR-10299 is resolved.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
