[ https://issues.apache.org/jira/browse/SOLR-10400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955433#comment-15955433 ]
Hoss Man commented on SOLR-10400: --------------------------------- bq. In a couple cases I see you're throwing IOException if the type isn't supported but I think it should be SolrException with BAD_REQUEST? That was a straight refactoring of the existing collapse code which throws IOException (which are later caught & rewrapped in SolrException) in general cleaning up collapse components error reporting/messages would probably be a good idea -- but that's an orthoginal scope to this issue. > refactor "instanceof TrieFooField || instanceof FooPointsField" to use > "FooValueFieldType" marker interface > ----------------------------------------------------------------------------------------------------------- > > Key: SOLR-10400 > URL: https://issues.apache.org/jira/browse/SOLR-10400 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) > Reporter: Hoss Man > Assignee: Hoss Man > Attachments: SOLR-10400.patch > > > See previous comment from smiley in SOLR-9994... > https://issues.apache.org/jira/browse/SOLR-9994?focusedCommentId=15875390&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15875390 > ...we already have the NumericValueFieldType marker interface and children. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org