[
https://issues.apache.org/jira/browse/SOLR-10007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson updated SOLR-10007:
----------------------------------
Attachment: SOLR-10007.patch
I think this is very close to ready, running tests and precommit and such again.
It touches a _lot_ of files, but most of them are changing
solrcore.getCoreDescriptor().getCoreContainer()
to
solrcore.getCoreContainer().
Along the way I renamed a few internal variables to more accurately reflect
what they're supposed to be.
There may be a few gratuitous format changes, I upgraded IntelliJ and somehow
had the "strip trailing spaces on save" set and "reformat whole file" rather
than "only reformat VCS changed text". I went through and undid all the
gratuitous junk I could find, but a few might have snuck through.
Structurally this is significantly better I think. There were a number of
places where we were using the CoreDescriptors to infer the state of the
SolrCore. The big thing this patch does is try to separate the use of
CoreDescriptors and SolrCores.
The other change here is it moves the CoreContainer reference from the
CoreDescriptor to SolrCore.
I'll commit this in a day or two unless there are objections. It' incorporates
both SOLR-10008 and SOLR-10009 so I'll close those now.
> Clean up references to CoreContainer and CoreDescriptors
> --------------------------------------------------------
>
> Key: SOLR-10007
> URL: https://issues.apache.org/jira/browse/SOLR-10007
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Affects Versions: trunk, 6.4
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Attachments: SOLR-10007.patch, SOLR-10007.patch
>
>
> It's a bit weird that CoreDescriptor contains a reference to CoreContainer.
> It seems like the SolrCore should reference CoreContainer.
> Similarly, SolrCore keeps a copy of CoreDescriptor and another copy is kept
> in the various CoreDescirptor lists making it difficult to track which is the
> "real" CoreDescriptor.
> This is an umbrella issue as I think this (and perhaps other) issues can be
> tackled separately.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
