[ https://issues.apache.org/jira/browse/LUCENE-7701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960652#comment-15960652 ]
Martijn van Groningen commented on LUCENE-7701: ----------------------------------------------- +1 I think this is a good change. I agree it should 7.0 only. > Refactor grouping collectors > ---------------------------- > > Key: LUCENE-7701 > URL: https://issues.apache.org/jira/browse/LUCENE-7701 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Alan Woodward > Attachments: LUCENE-7701.patch, LUCENE-7701.patch > > > Grouping currently works via abstract collectors, which need to be overridden > for each way of defining a group - currently we have two, 'term' (based on > SortedDocValues) and 'function' (based on ValueSources). These collectors > all have a lot of repeated code, and means that if you want to implement your > own group definitions, you need to override four or five different classes. > This would be easier to deal with if instead the 'group selection' code was > abstracted out into a single interface, and the various collectors were > changed to concrete implementations. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org