[ 
https://issues.apache.org/jira/browse/LUCENE-7736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963970#comment-15963970
 ] 

Alan Woodward commented on LUCENE-7736:
---------------------------------------

bq. I'm wondering whether we should try to detect double rewrite

So have an AssertingDoubleValuesSource?  I like that idea, although I'm not 
sure where it would get injected into the tests.

bq. wouldn't LongValueSource be more fitting/appropriate?

DoubleValuesSource is used in more places though (FunctionScoreQuery, 
Expressions module), so I think it's more useable this way.  I guess I see 
LongValuesSource as a convenience wrapper, and DoubleValuesSource as the core 
API.

> Expose some IndexReader stats via DoubleValuesSources
> -----------------------------------------------------
>
>                 Key: LUCENE-7736
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7736
>             Project: Lucene - Core
>          Issue Type: New Feature
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>            Priority: Minor
>         Attachments: LUCENE-7736.patch, LUCENE-7736.patch
>
>
> We have a number of ValueSource implementations that expose IndexReader stats 
> (numDocs, termFreq, etc).  We should re-implement these as 
> DoubleValuesSources, allowing them to be used in FunctionScoreQuery, etc.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to