[ 
https://issues.apache.org/jira/browse/SOLR-2537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038264#comment-13038264
 ] 

Gabriele Kahlout commented on SOLR-2537:
----------------------------------------

{quote}I was able to reproduce{quote}
Could you please let it be know there?!

{quote}If I were you, I would copy/paste a similar test from Solr's source 
tree, get that to succeed in your context, then tweak it to get to what you 
want to test.{quote}

That's always the way to do! What I even try to do is modify the test write 
there, because otherwise more often than not copy-pasting a method I end-up 
needing to copy-paste the whole package, but then there's a dependency on 
X-Y-Z, etc..

Looking at SolrBasicFunctionalityTest I was able to test what I want against r 
1104120 + my structural refactoring. Now checking out without the refactoring 
one of them complains about java.lang.NoSuchFieldError: core at 
org.apache.lucene.index.SegmentTermDocs.<init>(SegmentTermDocs.java:48).
I find it difficult to believe that the structural refactorings were 
responsible for avoiding this though!


> Refactor Solr modules structure
> -------------------------------
>
>                 Key: SOLR-2537
>                 URL: https://issues.apache.org/jira/browse/SOLR-2537
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Gabriele Kahlout
>            Priority: Minor
>             Fix For: 3.1.1
>
>
> Solr modules are nested in a non-standard archeotype (e.g. Solr Core module 
> is in the src dir of Solr parent).
> Also, a workaround for avoiding maven dependencies between Solr Core and 
> Testframework makes it impossible to add a depenency on Solr-3.2-SNAPHOST 
> (Solr Search Server) since it's packaged as a war, to import 
> EmbeddedSolrServer.java, for example. It has been discussed on the mailing 
> list[1].
> I've, in the mlist, suggested to "create yet one more module for Tests which 
> depend on Solr Core and on the Test Framework. The org burden of that extra 
> module, versus the ease of building configuration, I believe, outweights."
> However I realize there's a major drawback in that, i.e. that Solr Core will 
> build without passing the tests in the other module. There're 2 solutions:
> 1. Make Solr Core a parent module that encompasses a thin Solr Core, the 
> TestFramework module, and the Tests-only module;
> 2. 'Downgrade' Testframework from being a fully-fledged module by moving the 
> packages under Solr Core. 
> 2a. Move them under Solr Core test packages.
> 2b. move them under Solr Core src
> To me 2a is most intuitive. Those that want a dependency on Solr 
> TestFramework declare it with <classifier>tests</classifier>, which packages 
> only the tests, and the Solr Core classes those require.[2][3]
> The same refactoring applies to lucuene.
> [1] 
> http://mail-archives.apache.org/mod_mbox/lucene-solr-user/201105.mbox/%3c2d127f11dc79714e9b6a43ac9458147fbad42...@suex07-mbx-03.ad.syr.edu%3e
> [2] http://maven.apache.org/guides/mini/guide-attached-tests.html
> [3] I've successfully used it before. 
> https://code.google.com/p/memorizeasy/source/browse/MemoPlatform/persistenceui/pom.xml

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to