Github user dweiss commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/187#discussion_r111553388
  
    --- Diff: 
lucene/analysis/morfologik/src/java/org/apache/lucene/analysis/uk/UkrainianMorfologikAnalyzer.java
 ---
    @@ -107,11 +107,18 @@ public UkrainianMorfologikAnalyzer(CharArraySet 
stopwords, CharArraySet stemExcl
       @Override
       protected Reader initReader(String fieldName, Reader reader) {
         NormalizeCharMap.Builder builder = new NormalizeCharMap.Builder();
    +    // different apostrophes
         builder.add("\u2019", "'");
    +    builder.add("\u0218", "'");
         builder.add("\u02BC", "'");
    +    builder.add("`", "'");
    +    builder.add("´", "'");
    +    // ignored characters
         builder.add("\u0301", "");
    -    NormalizeCharMap normMap = builder.build();
    +    builder.add("\u00AD", "");
    +    builder.add("\uFEFF", "");
    --- End diff --
    
    byte order mark shouldn't be replaced to nothing... if you have a byte 
order mark in your character input (reader) then your conversion from bytes is 
screwed up somewhere before.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to