[ https://issues.apache.org/jira/browse/SOLR-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972086#comment-15972086 ]
David Smiley commented on SOLR-1485: ------------------------------------ Just a couple tidbits of feedback on the patch: * {{computePayloadFactor}} would probably get called a ton of times, thus it's worth trying to ensure it's implementation is quick. I see you having it doing "integer" & "float" string comparisons. That can be done beforehand; perhaps declare a {{java.util.ToDoubleFunction}} initialized with one of 3 lambdas depending on the situation. * FloatPayloadValueSource confuses me... ValueSources produce a value _per document_ yet payloads are _per term *occurrence*_. What use-case do you have in mind? > Payload scoring support > ----------------------- > > Key: SOLR-1485 > URL: https://issues.apache.org/jira/browse/SOLR-1485 > Project: Solr > Issue Type: New Feature > Components: search > Reporter: Erik Hatcher > Assignee: Erik Hatcher > Priority: Minor > Fix For: master (7.0) > > Attachments: PayloadTermQueryPlugin.java, payload_value_source.png, > SOLR-1485.patch > > > Solr has no support for Lucene's PayloadScoreQuery, yet it has support for > indexing payloads (via DelimitedPayloadTokenFilter or > NumericPayloadTokenFilter). > This issue adds value source and query parser support for leveraging payloads > created by those token filters. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org