Github user jitka18 commented on the issue:
https://github.com/apache/lucene-solr/pull/189
Hi, Christine. Sounds good---I hope to have time this evening to catch up
with the collaboration business. Thanks for fixing the indentation in your
most recent commit on your fork. I suppose the commit before that is a
matter of taste---it seemed strange to me to feed the constructor values
that we know might not be the final ones and then to turn around
immediately and adjust them, but there is less duplication the way you have
it. Your way is fine with me. We could probably do some tweaks here and
there and come up with something even cleaner but I'd rather stay focused
for now.
Thanks,
Judith
On Tue, Apr 18, 2017 at 11:35 AM, Christine Poerschke <
[email protected]> wrote:
> Hi Judith - I've just gone to https://github.com/cpoerschke/
> lucene-solr/settings/collaboration and invited you as a collaborator for
> my lucene-solr fork here on github. If you'd be happy to do the same then
> we can send each other pull requests. The two top commits on
> https://github.com/cpoerschke/lucene-solr/tree/jira/solr-6203 as one PR
> for example, easier to send a PR rather than comment in the code? Thanks.
-
> Christine
>
> â
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/lucene-solr/pull/189#issuecomment-294939923>,
> or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/AZdish3CJy4tMZGVy4XqORvWniPu05Vvks5rxQJegaJpZM4M-ruZ>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
