[
https://issues.apache.org/jira/browse/SOLR-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038852#comment-13038852
]
Simon Willnauer commented on SOLR-2530:
---------------------------------------
bq. I've looked into this in the past - its fine. Perhaps it's safer to change
it (equals or enum or whatever), but all current usage uses the same constant.
alright, I changed the todo to point out that we should cut over to an enum or
something similar. This is totally unrelated but wanted to make sure it doesn't
get lost.
I will commit in a minute
> Remove Noggit CharArr from FieldType
> ------------------------------------
>
> Key: SOLR-2530
> URL: https://issues.apache.org/jira/browse/SOLR-2530
> Project: Solr
> Issue Type: Improvement
> Components: Schema and Analysis
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Priority: Minor
> Labels: api-change
> Fix For: 4.0
>
> Attachments: SOLR-2530.patch, SOLR-2530.patch, SOLR-2530.patch,
> SOLR-2530.patch, SOLR-2530.patch, SOLR-2530.patch
>
>
> FieldType#indexedToReadable(BytesRef, CharArr) uses a noggit dependency that
> also spreads into ByteUtils. The uses of this method area all convert to
> String which makes this extra reference and the dependency unnecessary. I
> refactored it to simply return string and removed ByteUtils entirely. The
> only leftover from BytesUtils is a constant, i moved that one to Lucenes
> UnicodeUtils. I will upload a patch in a second
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
