[
https://issues.apache.org/jira/browse/SOLR-10489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980329#comment-15980329
]
Mikhail Khludnev commented on SOLR-10489:
-----------------------------------------
I've got a failure locally.
{code}
[junit4] 2> 693939 INFO
(TEST-StatsReloadRaceTest.testParallelReloadAndStats-seed#[FD888D7C65C51E79]) [
] o.a.s.h.a.CoreAdminOperation Checking request status for : 1
[junit4] 2> 693940 INFO
(searcherExecutor-2408-thread-1-processing-x:collection1 1 RELOAD) [
x:collection1] o.a.s.c.SolrCore [collection1] Registered new searcher
Searcher@6562708c[collection1]
main{ExitableDirectoryReader(UninvertingDirectoryReader(Uninverting(_0(7.0.0):C11)))}
[junit4] 2> 693940 INFO
(parallelCoreAdminExecutor-2401-thread-1-processing-1 RELOAD) [
x:collection1] o.a.s.s.SolrIndexSearcher Opening
[Searcher@2851a031[collection1] main]
[junit4] 2> 693940 INFO
(parallelCoreAdminExecutor-2401-thread-1-processing-1 RELOAD) [
x:collection1] o.a.s.c.SolrCore [collection1] CLOSING SolrCore
org.apache.solr.core.SolrCore@39c5ee88
[junit4] 2> 693941 INFO
(parallelCoreAdminExecutor-2401-thread-1-processing-1 RELOAD) [
x:collection1] o.a.s.m.SolrMetricManager Closing metric reporters for
registry=solr.core.collection1, tag=969272968
[junit4] 2> 693943 INFO
(searcherExecutor-2408-thread-1-processing-x:collection1 1 RELOAD) [
x:collection1] o.a.s.c.SolrCore [collection1] Registered new searcher
Searcher@2851a031[collection1]
main{ExitableDirectoryReader(UninvertingDirectoryReader(Uninverting(_0(7.0.0):C11)))}
[junit4] 2> 703982 INFO
(TEST-StatsReloadRaceTest.testParallelReloadAndStats-seed#[FD888D7C65C51E79]) [
] o.a.s.SolrTestCaseJ4 ###Ending testParallelReloadAndStats
[junit4] 2> NOTE: reproduce with: ant test -Dtestcase=StatsReloadRaceTest
-Dtests.method=testParallelReloadAndStats -Dtests.seed=FD888D7C65C51E79
-Dtests.slow=true -Dtests.locale=no-NO -Dtests.timezone=Pacific/Fakaofo
-Dtests.asserts=true -Dtests.file.encoding=UTF-8
[junit4] FAILURE 10.3s J1 | StatsReloadRaceTest.testParallelReloadAndStats
<<<
[junit4] > Throwable #1: java.lang.AssertionError: Key
SEARCHER.searcher.indexVersion not found in registry solr.core.collection1
[junit4] > at
__randomizedtesting.SeedInfo.seed([FD888D7C65C51E79:3216E845EA347626]:0)
[junit4] > at
org.apache.solr.handler.admin.StatsReloadRaceTest.requestMetrics(StatsReloadRaceTest.java:132)
[junit4] > at
org.apache.solr.handler.admin.StatsReloadRaceTest.testParallelReloadAndStats(StatsReloadRaceTest.java:70)
[junit4] > at java.lang.Thread.run(Thread.java:745)
{code}
The earlier version of this test (SOLR-9330 see branch_6x) just asserts that
there was no exception from the stats call. The current master version asserts
that metric is published during core reload in 10 sec. I don't know about new
metrics' design, but earlier there was no such guarantee. I suppose it requires
a separate development.
Here is the proposal:
- make parallel checks more opportunistic, just check that there is no
exception, and roughly check the version if it exists, but not rely on it.
- After reload is completed it can make the current strong check, but only if
asynchronous listeners don't delay publishing the metric.
What do you think about it?
> StatsReloadRaceTest.testParallelReloadAndStats failures
> -------------------------------------------------------
>
> Key: SOLR-10489
> URL: https://issues.apache.org/jira/browse/SOLR-10489
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Affects Versions: master (7.0)
> Reporter: Andrzej Bialecki
> Assignee: Erick Erickson
>
> This test has been failing a lot after the changes in SOLR-9959, for unclear
> reasons. The failure is always in the same place:
> {code}
> java.lang.AssertionError: Key SEARCHER.searcher.indexVersion not found in
> registry solr.core.collection1
> at
> __randomizedtesting.SeedInfo.seed([28B54D77FD0E3DF1:E72B284E72FF55AE]:0)
> at org.junit.Assert.fail(Assert.java:93)
> at org.junit.Assert.assertTrue(Assert.java:43)
> at
> org.apache.solr.handler.admin.StatsReloadRaceTest.requestMetrics(StatsReloadRaceTest.java:132)
> at
> org.apache.solr.handler.admin.StatsReloadRaceTest.testParallelReloadAndStats(StatsReloadRaceTest.java:70)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
