[
https://issues.apache.org/jira/browse/LUCENE-3144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039176#comment-13039176
]
Robert Muir commented on LUCENE-3144:
-------------------------------------
Thanks for tracking this one down Shai!
After fixing this, is it then possible to fail lucene tests if we cannot delete
the directory, or are there still issues with special tests?
> MockIndexOutputWrapper should close() if
> dir.maybeThrowDeterminsticException() throws an exception
> --------------------------------------------------------------------------------------------------
>
> Key: LUCENE-3144
> URL: https://issues.apache.org/jira/browse/LUCENE-3144
> Project: Lucene - Java
> Issue Type: Test
> Components: general/test
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Minor
> Fix For: 3.2, 4.0
>
> Attachments: LUCENE-3144.patch, LUCENE-3144.patch
>
>
> MockIndexOutputWrapper checks in various places
> dir.maybeThrowDeterminsticException(). If an exception is actually thrown,
> the IndexOutput is not closed, and therefore file handles remain open which
> prevent cleaning up directories on Windows (and LTC.afterClass prints nasty
> stack traces).
> We should wrap every call with a try-catch -- if an exception is thrown, we
> should close() the underlying stream. This should be done to backwards too
> (in 3x).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
