[ 
https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15983273#comment-15983273
 ] 

Mike Drob edited comment on SOLR-9555 at 4/25/17 6:50 PM:
----------------------------------------------------------

Here's a patch that fixes the resource leak. I'm still getting a different kind 
of failure now, that doesn't reproduce for me. It shouldn't be happening at all 
since the previous two asserts check for each of the docs individually, so I 
don't understand how they could be missing on the next query. Going to need 
help on figuring out what's wrong here.

Maybe related to SOLR-10562, since there is a difference between using RTG or 
not after a commit.

{noformat}
  2> NOTE: reproduce with: ant test  -Dtestcase=ForceLeaderTest 
-Dtests.method=testReplicasInLIRNoLeader -Dtests.seed=B6BDBFC48B148FB6 
-Dtests.slow=true -Dtests.locale=en -Dtests.timezone=Europe/Belgrade 
-Dtests.asserts=true -Dtests.file.encoding=US-ASCII
[11:25:21.677] FAILURE 45.6s | ForceLeaderTest.testReplicasInLIRNoLeader <<<
   > Throwable #1: java.lang.AssertionError: Expected only 2 documents in the 
index expected:<2> but was:<0>
   >    at 
__randomizedtesting.SeedInfo.seed([B6BDBFC48B148FB6:502A8B04B29676D7]:0)
   >    at org.junit.Assert.fail(Assert.java:93)
   >    at org.junit.Assert.failNotEquals(Assert.java:647)
   >    at org.junit.Assert.assertEquals(Assert.java:128)
   >    at org.junit.Assert.assertEquals(Assert.java:472)
   >    at 
org.apache.solr.cloud.ForceLeaderTest.testReplicasInLIRNoLeader(ForceLeaderTest.java:152)
{noformat}

Edit: When I say "doesn't reproduce" I mean that rerunning with the same seed 
doesn't cause it to always fail, but running {{ant test}} will get a failure 
maybe 20% of the time.


was (Author: mdrob):
Here's a patch that fixes the resource leak. I'm still getting a different kind 
of failure now, that doesn't reproduce for me. It shouldn't be happening at all 
since the previous two asserts check for each of the docs individually, so I 
don't understand how they could be missing on the next query. Going to need 
help on figuring out what's wrong here.

Maybe related to SOLR-10562, since there is a difference between using RTG or 
not after a commit.

{noformat}
  2> NOTE: reproduce with: ant test  -Dtestcase=ForceLeaderTest 
-Dtests.method=testReplicasInLIRNoLeader -Dtests.seed=B6BDBFC48B148FB6 
-Dtests.slow=true -Dtests.locale=en -Dtests.timezone=Europe/Belgrade 
-Dtests.asserts=true -Dtests.file.encoding=US-ASCII
[11:25:21.677] FAILURE 45.6s | ForceLeaderTest.testReplicasInLIRNoLeader <<<
   > Throwable #1: java.lang.AssertionError: Expected only 2 documents in the 
index expected:<2> but was:<0>
   >    at 
__randomizedtesting.SeedInfo.seed([B6BDBFC48B148FB6:502A8B04B29676D7]:0)
   >    at org.junit.Assert.fail(Assert.java:93)
   >    at org.junit.Assert.failNotEquals(Assert.java:647)
   >    at org.junit.Assert.assertEquals(Assert.java:128)
   >    at org.junit.Assert.assertEquals(Assert.java:472)
   >    at 
org.apache.solr.cloud.ForceLeaderTest.testReplicasInLIRNoLeader(ForceLeaderTest.java:152)
{noformat}

> Leader incorrectly publishes state for replica when it puts replica into LIR.
> -----------------------------------------------------------------------------
>
>                 Key: SOLR-9555
>                 URL: https://issues.apache.org/jira/browse/SOLR-9555
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Alan Woodward
>         Attachments: SOLR-9555.patch, SOLR-9555.patch, SOLR-9555-WIP-2.patch, 
> SOLR-9555-WIP-3.patch, SOLR-9555-WIP.patch
>
>
> See 
> https://jenkins.thetaphi.de/job/Lucene-Solr-master-Linux/17888/consoleFull 
> for an example



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to