[
https://issues.apache.org/jira/browse/SOLR-9386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15989049#comment-15989049
]
Shawn Heisey commented on SOLR-9386:
------------------------------------
[~steve_rowe], could we completely remove that parseProperties method from Solr
code and just let ZK handle it? I see that there's still some excedption
handling code there after your change, but IMHO we should let ZK handle any
problems or throw relevant exceptions.
There's another issue where somebody wanted to use a config option in the
embedded zookeeper supported by 3.4 but not the the 3.2 version the
parseProperties method was copied from ... so it didn't work. I can't seem to
locate that issue now. I'm pretty sure that in the patch for that issue, I
completely removed the method and didn't have any problems.
> Upgrade Zookeeper to 3.4.10
> ---------------------------
>
> Key: SOLR-9386
> URL: https://issues.apache.org/jira/browse/SOLR-9386
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Steve Rowe
> Assignee: Steve Rowe
> Fix For: 6.6, master (7.0)
>
> Attachments: SOLR-9386.patch, SOLR-9386.patch, SOLR-9386.patch,
> zookeeper-3.4.8-upgrade-tests-pass.patch,
> zookeeper-3.4.9-upgrade-tests-fail.patch
>
>
> Zookeeper 3.4.10 release should be happening fairly soon, and the ZK issue
> blocking incorporation into Solr (ZOOKEEPER-2383) has a 3.4.10-targetted
> patch that fixes the test failures problem noted on SOLR-8724.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
