[
https://issues.apache.org/jira/browse/SOLR-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15989536#comment-15989536
]
Mikhail Khludnev commented on SOLR-9867:
----------------------------------------
{code}
diff --git a/solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java
b/solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java
index 39ccadc..ab46f19 100644
--- a/solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java
+++ b/solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java
@@ -96,6 +96,8 @@
private Boolean testMode = null;
private boolean isV2Enabled =
!"true".equals(System.getProperty("disable.v2.api", "false"));
+ private volatile boolean initIsDone;
+
/**
* Enum to define action that needs to be processed.
* PASSTHROUGH: Pass through to Restlet via webapp.
@@ -182,6 +184,7 @@
}
log.trace("SolrDispatchFilter.init() done");
+ initIsDone = true;
}
private void setupJvmMetrics() {
@@ -307,6 +310,7 @@
}
public void doFilter(ServletRequest request, ServletResponse response,
FilterChain chain, boolean retry) throws IOException, ServletException {
+ assert initIsDone:"I swear";
if (!(request instanceof HttpServletRequest)) return;
try {
{code}
{code}
305 INFO (Thread-1) [ ] o.a.s.s.SolrDispatchFilter ___ _
Welcome to Apache Solr™ version 7.0.0
305 INFO (Thread-1) [ ] o.a.s.s.SolrDispatchFilter / __| ___| |_ _
Starting in standalone mode on port 52215
305 INFO (Thread-1) [ ] o.a.s.s.SolrDispatchFilter \__ \/ _ \ | '_|
Install dir: null
321 INFO (Thread-1) [ ] o.a.s.s.SolrDispatchFilter |___/\___/_|_| Start
time: 2017-04-28T22:25:03.738Z
335 INFO (Thread-1) [ ] o.a.s.c.SolrResourceLoader solr home defaulted to
'solr/' (could not find system property or JNDI)
341 INFO (Thread-1) [ ] o.a.s.c.SolrXmlConfig Loading container
configuration from
/private/var/folders/rg/fr1t3mx9391f1_g0xs8wtq2d1xv078/T/solr.util.TestSolrCLIRunExample_E157FC17061E2B1D-001/tempDir-001/schemaless/solr/solr.xml
465 WARN (qtp151277770-21) [ ] o.e.j.s.ServletHandler Error for
/solr/admin/info/system
java.lang.AssertionError: I swear
at
org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:313)
at
org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:309)
at
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1699)
at
org.apache.solr.client.solrj.embedded.JettySolrRunner$DebugFilter.doFilter(JettySolrRunner.java:139)
at
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1699)
at
org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:582)
at
org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:224)
at
org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1180)
at
org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:512)
at
org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
at
org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1112)
at
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
at
org.eclipse.jetty.server.handler.gzip.GzipHandler.handle(GzipHandler.java:462)
at
org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134)
at org.eclipse.jetty.server.Server.handle(Server.java:534)
{code}
So, what we gonna do, then...
> The Solr examples can not always be started after being stopped due to race
> with loading core.
> ----------------------------------------------------------------------------------------------
>
> Key: SOLR-9867
> URL: https://issues.apache.org/jira/browse/SOLR-9867
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Mark Miller
> Priority: Critical
> Fix For: 6.6, master (7.0)
>
> Attachments: SDF init and doFilter in parallel.png, SOLR-9867.patch,
> SOLR-9867.patch, SOLR-9867-test.patch
>
>
> I'm having trouble when I start up the schemaless example after shutting down.
> I first tracked this down to the fact that the run example tool is getting an
> error when it tries to create the SolrCore (again, it already exists) and so
> it deletes the cores instance dir which leads to tlog and index lock errors
> in Solr.
> The reason it seems to be trying to create the core when it already exists is
> that the run example tool uses a core status call to check existence and
> because the core is loading, we don't consider it as existing. I added a
> check to look for core.properties.
> That seemed to let me start up, but my first requests failed because the core
> was still loading. It appears CoreContainer#getCore is supposed to be
> blocking so you don't have this problem, but there must be an issue, because
> it is not blocking.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
