[
https://issues.apache.org/jira/browse/LUCENE-7719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15989866#comment-15989866
]
David Smiley commented on LUCENE-7719:
--------------------------------------
[~mikemccand] What do you think of the patch? In particular, I wonder what you
think of:
* AutomatonQuery.isAutomatonBinary(). This is a very simple/innocent addition.
It's a shame Automaton.isBinary (or something similar) doesn't exist.
* See my TODO last paragraph above. Also note even if that were done, the
CompiledAutomaton isn't exposed by AutomatonQuery any way; so we'd need an
accessor. Perhaps alternatively AutomatonQuery might expose both a
CharRunAutomaton and ByteRunAutomaton (i.e. move some of the code in this patch
to there)? If that wouldn't potentially be useful to other users then
nevermind.
* The approach to convert chars to bytes at each step
> UnifiedHighlighter doesn't handle some AutomatonQuery's with multi-byte chars
> -----------------------------------------------------------------------------
>
> Key: LUCENE-7719
> URL: https://issues.apache.org/jira/browse/LUCENE-7719
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/highlighter
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Minor
> Attachments: LUCENE_7719.patch
>
>
> In MultiTermHighlighting, a CharacterRunAutomaton is being created that takes
> the result of AutomatonQuery.getAutomaton that in turn is byte oriented, not
> character oriented. For ASCII terms, this is safe but it's not for
> multi-byte characters. This is most likely going to rear it's head with a
> WildcardQuery, but due to special casing in MultiTermHighlighting,
> PrefixQuery isn't affected. Nonetheless it'd be nice to get a general fix in
> so that MultiTermHighlighting can remove special cases for PrefixQuery and
> TermRangeQuery (both subclass AutomatonQuery).
> AFAICT, this bug was likely in the PostingsHighlighter since inception.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
