[ https://issues.apache.org/jira/browse/SOLR-9527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hrishikesh Gadre updated SOLR-9527: ----------------------------------- Attachment: SOLR-9527.patch [~varunthacker] I have addressed all the review comments. In addition I also added a unit test to verify createNodeSet functionality. I made few changes along the way, (a) Added support for configuring createNodeSet.shuffle parameter for restore command. (b) The logic in RestoreCmd.java comparing the current num_live_nodes against the num_nodes for backup collection was not quite correct since it was not considering the createNodeSet as well as maxShardsPerNode parameters. So I fixed that logic. (c) Fixed UpdateRequestProcessorFactoryTest (unrelated to these changes). It was failing for following combination of parameters, {noformat} ant test -Dtestcase=UpdateRequestProcessorFactoryTest -Dtests.method=testRequestTimeUrp -Dtests.seed=91817E95F0748507 -Dtests.slow=true -Dtests.locale=be-BY -Dtests.timezone=America/Indiana/Vevay -Dtests.asserts=true -Dtests.file.encoding=UTF-8 {noformat} Can you take a look and let me know your feedback? > Solr RESTORE api doesn't distribute the replicas uniformly > ----------------------------------------------------------- > > Key: SOLR-9527 > URL: https://issues.apache.org/jira/browse/SOLR-9527 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Affects Versions: 6.1 > Reporter: Hrishikesh Gadre > Assignee: Varun Thacker > Attachments: SOLR-9527.patch, SOLR-9527.patch, SOLR-9527.patch, > SOLR-9527.patch, SOLR-9527.patch, Solr 9527.pdf > > > Please refer to this email thread for details, > http://lucene.markmail.org/message/ycun4x5nx7lwj5sk?q=solr+list:org%2Eapache%2Elucene%2Esolr-user+order:date-backward&page=1 -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org