[ 
https://issues.apache.org/jira/browse/SOLR-10619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15999586#comment-15999586
 ] 

Scott Blum commented on SOLR-10619:
-----------------------------------

I completely follow your logic.  But then, why do we need a singleConsumer 
flag?  Couldn't we just do the optimization in all cases?

In other words, let's say we're dirty but we have children in memory.  Fine, 
let's optimistically fetch the first child's data based on the node name we 
have in memory.  If it succeeds, we're done, just return it.

But if it fails, if there's no node then, and we're in a dirty state, THEN we 
can refetch the child list from ZK.

> When DQ.knowChildren is not empty, DQ should not refetch node children in 
> case of single consumer
> -------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-10619
>                 URL: https://issues.apache.org/jira/browse/SOLR-10619
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Cao Manh Dat
>            Assignee: Cao Manh Dat
>         Attachments: SOLR-10619.patch, SOLR-10619.patch
>
>
> Right now, for every time childWatcher is kicked off. We refetch all children 
> of DQ's node. It is a wasted in case of single consumer.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to