[ 
https://issues.apache.org/jira/browse/SOLR-10285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16001160#comment-16001160
 ] 

Erick Erickson commented on SOLR-10285:
---------------------------------------

Joshua:

"Yonik's law of patches" reads "A half-baked patch with no documentation, no 
tests and no backwards compatibility is better than no patch at all.". 

Please feel free to attach a patch even if it's not complete (even if it 
doesn't even _compile_!), with appropriate disclaimers. Even if someone picks 
up this JIRA and decides to use another approach they'll be able to benefit 
from what they see of your work.

It also is good if you mention that you won't be working on it, that way people 
won't wait if they want to pick it up.

Best,
Erick

> Reduce state messages when there are leader only shards
> -------------------------------------------------------
>
>                 Key: SOLR-10285
>                 URL: https://issues.apache.org/jira/browse/SOLR-10285
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Varun Thacker
>            Assignee: Cao Manh Dat
>
> For shards which have 1 replica ( leader ) we know it doesn't need to recover 
> from anyone. We should short-circuit the recovery process in this case. 
> The motivation for this being that we will generate less state events and be 
> able to mark these replicas as active again without it needing to go into 
> 'recovering' state. 
> We already short circuit when you set {{-Dsolrcloud.skip.autorecovery=true}} 
> but that sys prop was meant for tests only. Extending this to make sure the 
> code short-circuits when the core knows its the only replica in the shard is 
> the motivation of the Jira.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to