[ 
https://issues.apache.org/jira/browse/LUCENE-7778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16013958#comment-16013958
 ] 

ASF GitHub Bot commented on LUCENE-7778:
----------------------------------------

Github user spmason closed the pull request at:

    https://github.com/apache/lucene-solr/pull/183


> Remove synchronized from high-contention methods on RAMFile
> -----------------------------------------------------------
>
>                 Key: LUCENE-7778
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7778
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/store
>            Reporter: Steve Mason
>            Priority: Minor
>
> When benchmarking RAMDirectory access via multiple threads the methods 
> {{RAMFile::numBuffers}} and {{RAMFile::getBuffer}} show up blocking threads 
> fairly frequently
> By removing the {{synchronized}} keyword from these methods our internal 
> benchmarks show a 2x performance increase under concurrent load.
> I don't think removing {{synchronized}} from these methods is a problem as 
> they are read-only and write access to these fields is not synchronized.  
> LUCENE-2779 also implies that some ofthe locking on RAMDirectory is not 
> necessary



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to