[
https://issues.apache.org/jira/browse/LUCENE-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040791#comment-13040791
]
Shai Erera commented on LUCENE-3150:
------------------------------------
We can fix IOUtils to do that -- now that we call it from many places in the
code, it will catch a lot of instances. Also, perhaps we could have an
Abortable interface and then call IOUtils from all places that impl abort()
today.
> Wherever we catch & suppress Throwable we should not suppress
> ThreadInterruptedException
> ----------------------------------------------------------------------------------------
>
> Key: LUCENE-3150
> URL: https://issues.apache.org/jira/browse/LUCENE-3150
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Michael McCandless
> Priority: Minor
> Fix For: 3.3, 4.0
>
>
> In various places we catch Throwable and suppress it, usually in exception
> handlers where we want to just throw the first exc we had hit.
> But this is dangerous for a thread interrupt since it means we can swallow &
> ignore the interrupt.
> We should at least catch the interrupt & restore the interrupt bit, if we
> can't rethrow it.
> One example is in SegmentInfos where we write the segments.gen file... there
> are many other examples in SegmentInfos too.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
