[
https://issues.apache.org/jira/browse/LUCENE-3147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040809#comment-13040809
]
Michael McCandless commented on LUCENE-3147:
--------------------------------------------
bq. Also, why do we call checkpoint() only if suppressWarnings=true and not
only if anyChanges=true?
Good question! My guess is the checkpoint() can be removed? We call
checkpoint up above after closeMergeReaders unconditionally...
bq. It's weird about MLFWrapper - when I 'svn stat' it appears w/ "A +" and not
"?". Yet "svn diff MLFW" yields no diff ... If I "svn ci", I see that it's
included in the list of files ... strange.
Ahh yes OK. This is from "svn merge" I think? Like "svn diff" won't show
it... maybe there's some option to svn diff to show these "added due to merge"
changes?
> MockDirectoryWrapper should track open file handles of IndexOutput too
> ----------------------------------------------------------------------
>
> Key: LUCENE-3147
> URL: https://issues.apache.org/jira/browse/LUCENE-3147
> Project: Lucene - Java
> Issue Type: Test
> Components: general/test
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Minor
> Fix For: 3.2, 4.0
>
> Attachments: LUCENE-3147-3x.patch, LUCENE-3147.patch,
> LUCENE-3147.patch, LUCENE-3147.patch, LUCENE-3147.patch, LUCENE-3147.patch,
> LUCENE-3147.patch, LUCENE-3147.patch, LUCENE-3147.patch, LUCENE-3147.patch,
> LUCENE-3147.patch, LUCENE-3147.patch, LUCENE-3147.patch, LUCENE-3147.patch
>
>
> MockDirectoryWrapper currently tracks open file handles of IndexInput only.
> Therefore IO files that are not closed do not fail our tests, which can then
> lead to test directories fail to delete on Windows. We should make sure all
> open files are tracked and if they are left open, fail the test. I'll attach
> a patch shortly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
