[
https://issues.apache.org/jira/browse/SOLR-10734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022500#comment-16022500
]
Amrit Sarkar edited comment on SOLR-10734 at 5/24/17 8:19 AM:
--------------------------------------------------------------
Ishan, thank you for sharing the concern,
I replaced the t.run() with t.start(), and the test failed for me once for this
seed:
ant test -Dtestcase=AtomicUpdateProcessorFactoryTest
-Dtests.method=testMultipleThreads -Dtests.seed=C2A82A0AA119D39F
-Dtests.slow=true -Dtests.locale=ar-KW -Dtests.timezone=Etc/GMT+11
-Dtests.asserts=true -Dtests.file.encoding=UTF-8
It failed multiple retires and eventually fails for version conflict but I am
not able to replicate the same ever since for any seed and the test is getting
passed successfully.
I am sure the test is not full proofed.
was (Author: sarkaramr...@gmail.com):
Ishan, thank you for sharing the concern,
I replaced the t.run() with t.start(), and the test failed for me once for this
seed:
ant test -Dtestcase=AtomicUpdateProcessorFactoryTest
-Dtests.method=testMultipleThreads -Dtests.seed=C2A82A0AA119D39F
-Dtests.slow=true -Dtests.locale=ar-KW -Dtests.timezone=Etc/GMT+11
-Dtests.asserts=true -Dtests.file.encoding=UTF-8
It failed multiple retires and eventually fails for version conflict but I am
not able to replicate the same ever since for any seed and the test is getting
passed successfully.
I am sure the test is not full proofed.
Can you share the seed or the log snippet from the failure.
> Multithreaded test/support for AtomicURP broken
> -----------------------------------------------
>
> Key: SOLR-10734
> URL: https://issues.apache.org/jira/browse/SOLR-10734
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Ishan Chattopadhyaya
> Attachments: log-snippet
>
>
> The multithreaded test doesn't actually start the threads, but only invokes
> the run directly. The join afterwards doesn't do anything, hence.
> {code}
> diff --git
> a/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateProcessorFactoryTest.java
>
> b/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateProcessorFactoryTest.java
> index f3f833d..10b7770 100644
> ---
> a/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateProcessorFactoryTest.java
> +++
> b/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateProcessorFactoryTest.java
> @@ -238,7 +238,7 @@ public class AtomicUpdateProcessorFactoryTest extends
> SolrTestCaseJ4 {
> }
> }
> };
> - t.run();
> + t.run(); // red flag, shouldn't this be t.start?
> threads.add(t);
> finalCount += index; //int_i
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
