[
https://issues.apache.org/jira/browse/SOLR-10755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026552#comment-16026552
]
Jason Gerlowski commented on SOLR-10755:
----------------------------------------
+1, especially for removing the deprecated {{SolrClient}} constructors.
One comment/suggestion/question:
{{SolrTestCaseJ4}} has a big collection of overloaded
getHttpSolrClient/getLBHttpSolrClient/getCloudSolrClient methods. These were
created back when the SolrClient builders were introduced to ensure that the
tests covered client construction using the builders as well as the many
director-constructor-use. With most of the {{SolrClient}} constructors going
away in this patch, I'm not sure that the get*SolrClient methods serve a
purpose anymore, and can be deleted. Would it make sense to clean that up as a
part of this JIRA?
(That'd expand the scope of this JIRA a bit, so it might also make sense to
create a follow-on JIRA that can get picked up whenever. Happy to help on a
patch if we split this into a separate JIRA.)
> delete/refactor (most) solrj deprecations on master
> ---------------------------------------------------
>
> Key: SOLR-10755
> URL: https://issues.apache.org/jira/browse/SOLR-10755
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Hoss Man
> Assignee: Hoss Man
> Priority: Blocker
> Fix For: master (7.0)
>
> Attachments: SOLR-10755.patch, SOLR-10755.patch
>
>
> using this issue to track some work i've done to cleanup deprecations in
> solrj for master (7.0)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
