[ https://issues.apache.org/jira/browse/LUCENE-7838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027295#comment-16027295 ]
Tommaso Teofili commented on LUCENE-7838: ----------------------------------------- bq. you added a dependency on the sandbox module from another module. That's quite surprising to me... I don't think that's legit? why? As soon as we provide releases of lucene-sandbox I assume we expect people and other modules to use it. bq. New inter-module dependencies (of any kind) I think should also deserve communication on the JIRA issue and I don't see any mention here. Since this is only impacting master branch I had thought there was no need to explicitly mention that; on the other hand {{FuzzyLikeThisQuery}} lives in sandbox therefore I had assumed there was no need to explicitly specify that in the issue. bq. I also don't see a CHANGES.txt entry right, there's no such entry. bq. I don't see a patch file either but I admit I welcome that I'm not sure I get your point here, would you have expected a patch ? > Add a knn classifier based on fuzzy like this > --------------------------------------------- > > Key: LUCENE-7838 > URL: https://issues.apache.org/jira/browse/LUCENE-7838 > Project: Lucene - Core > Issue Type: Bug > Components: modules/classification > Reporter: Tommaso Teofili > Assignee: Tommaso Teofili > Fix For: master (7.0) > > > FLT mixes fuzzy and MLT, in the context of Lucene based classification it > might be useful to add such a fuzziness to a dedicated KNN classifier (based > on FLT queries). -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org