[ https://issues.apache.org/jira/browse/LUCENE-7723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027868#comment-16027868 ]
Alan Woodward commented on LUCENE-7723: --------------------------------------- Thinking this over, I'm tempted to move the function and scoringFunction ValuesSources to the test module and not try and implement equals/hashCode() for them. They're fairly esoteric, and clients are far more likely to use something like the expressions module for this sort of thing. > LongValuesSource/DoubleValuesSource impls should implement equals/hashCode > -------------------------------------------------------------------------- > > Key: LUCENE-7723 > URL: https://issues.apache.org/jira/browse/LUCENE-7723 > Project: Lucene - Core > Issue Type: Task > Reporter: Adrien Grand > Attachments: LUCENE-7723.patch > > > Given that we embed values sources in queries and sorts, from which we expect > that they have working equals/hashCode, we should also implement > equals/hashCode on LongValuesSource/DoubleValuesSource impls. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org