[ 
https://issues.apache.org/jira/browse/SOLR-8668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029637#comment-16029637
 ] 

Christine Poerschke commented on SOLR-8668:
-------------------------------------------

bq. The one thing that jumped out at me is 
SolrIndexConfig.effectiveUseCompoundFileSetting. ...

Good catch that! I've gone and renamed from _effectiveUseCompoundFileSetting_ 
to _useCompoundFile_ (with no _get...()_) accessor to match the style of the 
other settings.

----

Changes from master merged into the working branch and tests pass for me 
locally. 
https://github.com/apache/lucene-solr/compare/jira/solr-8668#files_bucket shows 
all the changes. Further comments and reviews welcome as usual.

If there are no further comments then I'll aim to commit this to master branch 
Thursday or Friday this week (June 1st or June 2nd).

> Remove support for <mergePolicy> (in favour of <mergePolicyFactory>)
> --------------------------------------------------------------------
>
>                 Key: SOLR-8668
>                 URL: https://issues.apache.org/jira/browse/SOLR-8668
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Shai Erera
>            Assignee: Christine Poerschke
>            Priority: Blocker
>             Fix For: master (7.0)
>
>         Attachments: SOLR-8668-part1.patch, SOLR-8668-part1.patch
>
>
> Following SOLR-8621, we should remove support for {{<mergePolicy>}} (and 
> related {{<mergeFactor>}} and {{<maxMergeDocs>}}) in trunk/6x.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to