[ 
https://issues.apache.org/jira/browse/SOLR-10782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shalin Shekhar Mangar updated SOLR-10782:
-----------------------------------------
    Attachment: SOLR-10782.patch

# Moved getJson method from SolrZkClient (where all methods throw 
KeeperException.NoNodeException if znode does not exist) to Utils and changed 
the behavior to return an empty map if node does not exist or is null. # Added 
a note of this behavior to its javadocs as well.
# Cleaned up its usage -- no null checks necessary anymore
# Fixed TestPolicyCloud.testDataProvider to treat freedisk, diskUsage and 
sysLoadAvg as doubles instead of longs. This also fixes a test bug where 
diskUsage or sysLoadAvg less than 1.0 would fail the test.

There are still a few comparisons to audit and fix.

> Improve error handling and tests for Snitch and subclasses
> ----------------------------------------------------------
>
>                 Key: SOLR-10782
>                 URL: https://issues.apache.org/jira/browse/SOLR-10782
>             Project: Solr
>          Issue Type: Sub-task
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: SolrCloud
>            Reporter: Shalin Shekhar Mangar
>            Assignee: Shalin Shekhar Mangar
>             Fix For: master (7.0)
>
>         Attachments: SOLR-10782.patch, SOLR-10782.patch
>
>
> Snitch has very little exception handling when communication to zookeeper or 
> other node breaks. It can do with some cleanup and tests.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to