[ 
https://issues.apache.org/jira/browse/SOLR-10804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034889#comment-16034889
 ] 

Sergio Garcia Maroto commented on SOLR-10804:
---------------------------------------------

I had a look to the source code and I see 
DocBasedVersionConstraintsProcessorFactory 

if (0 < ((Comparable)newUserVersion).compareTo((Comparable) 
oldUserVersion)) { 
          // log.info("VERSION returning true (proceed with update)" ); 
          return true; 
} 

I can't find a way of overwriting same version without changing that piece 
of code. 
Would be possible to add a parameter to the 
"DocBasedVersionConstraintsProcessorFactory" something like 
"overwrite.same.version=true" 
so the new code would look like. 


int compareTo = ((Comparable)newUserVersion).compareTo((Comparable) 
oldUserVersion); 
if ( ((overwritesameversion) && 0 <= compareTo) || (0 < compareTo)) { 
          // log.info("VERSION returning true (proceed with update)" ); 
          return true; 
} 


Is that thing going to break anyhting? Can i do that change? 

Thanks 
Sergio 

> Document Centric Versioning Constraints - Overwrite same version
> ----------------------------------------------------------------
>
>                 Key: SOLR-10804
>                 URL: https://issues.apache.org/jira/browse/SOLR-10804
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: SolrCloud
>    Affects Versions: 6.1
>            Reporter: Sergio Garcia Maroto
>             Fix For: master (7.0)
>
>
> It would be nice to have the possibility to overwrite documents with the same 
> external version.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to