[
https://issues.apache.org/jira/browse/LUCENE-7500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044990#comment-16044990
]
Michael McCandless commented on LUCENE-7500:
--------------------------------------------
bq. I filed LUCENE-7875 to keep the scope of this current issue more manageable.
Thanks.
bq. The inner class SingleFieldFilterLeafReader has documentation and a decent
name;
Oh, sorry, that documentation looks great ... I was just reading the patch out
of context.
bq. My change is not purely identical in behavior, yes.
I think we shouldn't change {{ParallelLeafReader}}'s behavior on this issue;
let this issue focus on the task at hand? Maybe open a follow-on issue to make
this change. I don't like {{ParallelLeafReader}}'s leniency ... the fields
users pass to it should be orthogonal across sub-readers and we really should
enforce that.
> Remove LeafReader.fields()
> --------------------------
>
> Key: LUCENE-7500
> URL: https://issues.apache.org/jira/browse/LUCENE-7500
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: David Smiley
> Assignee: David Smiley
> Fix For: master (7.0)
>
> Attachments: LUCENE_7500_avoid_leafReader_fields.patch,
> LUCENE_7500_avoid_leafReader_fields.patch,
> LUCENE_7500_Remove_LeafReader_fields.patch,
> LUCENE_7500_Remove_LeafReader_fields.patch
>
>
> {{Fields}} seems like a pointless intermediary between the {{LeafReader}} and
> {{Terms}}. Why not have {{LeafReader.getTerms(fieldName)}} instead? One loses
> the ability to get the count and iterate over indexed fields, but it's not
> clear what real use-cases are for that and such rare needs could figure that
> out with FieldInfos.
> [~mikemccand] pointed out that we'd probably need to re-introduce a
> {{TermVectors}} class since TV's are row-oriented not column-oriented. IMO
> they should be column-oriented but that'd be a separate issue.
> _(p.s. I'm lacking time to do this w/i the next couple months so if someone
> else wants to tackle it then great)_
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
