[ https://issues.apache.org/jira/browse/SOLR-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041711#comment-13041711 ]
Michael McCandless commented on SOLR-2193: ------------------------------------------ I haven't looked that closely a this patch yet, but it already fixes a long standing problem in Solr, that a long running merge blocks a Solr commit, because it switches to IW.commit instead of closing/opening the writer. This seems like a great step forward? Sure, we should pursue moving IW to SolrCore, cutting over to IW's NRT's APIs, making all caching per-segment, etc., but these should not block committing this improvement; they can be pursued as followon/parallel issues: progress not perfection. > Re-architect Update Handler > --------------------------- > > Key: SOLR-2193 > URL: https://issues.apache.org/jira/browse/SOLR-2193 > Project: Solr > Issue Type: Improvement > Reporter: Mark Miller > Fix For: 4.0 > > Attachments: SOLR-2193.patch, SOLR-2193.patch, SOLR-2193.patch, > SOLR-2193.patch, SOLR-2193.patch, SOLR-2193.patch > > > The update handler needs an overhaul. > A few goals I think we might want to look at: > 1. Cleanup - drop DirectUpdateHandler(2) line - move to something like > UpdateHandler, DefaultUpdateHandler > 2. Expose the SolrIndexWriter in the api or add the proper abstractions to > get done what we now do with special casing: > if (directupdatehandler2) > success > else > failish > 3. Stop closing the IndexWriter and start using commit (still lazy IW init > though). > 4. Drop iwAccess, iwCommit locks and sync mostly at the Lucene level. > 5. Keep NRT support in mind. > 6. Keep microsharding in mind (maintain logical index as multiple physical > indexes) > 7. Address the current issues we face because multiple original/'reloaded' > cores can have a different IndexWriter on the same index. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org