[ 
https://issues.apache.org/jira/browse/SOLR-10867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amrit Sarkar updated SOLR-10867:
--------------------------------
    Attachment: SOLR-10867.patch
                error

Thanks [~shalinmangar] for the correction, I have to be more careful,  Well 
that rectified thread leaks rightfully as only one core is being created in the 
main thread, the temp index dir is still creating issue while getting removed 
at core destruction.

Update patch and error:

{code}
[junit4]   2> 28935 ERROR (coreCloseExecutor-12-thread-1) [    x:collection1] 
o.a.s.c.CachingDirectoryFactory Timeout waiting for all directory ref counts to 
be released - gave up waiting on 
CachedDir<<refCount=1;path=/Users/amritsarkar/git_space/solr-june/lucene-solr/solr/build/solr-core/test/J0/temp/solr.update.processor.ClassificationUpdateProcessorFactoryTest_57912E1D960F4206-001/init-core-data-001/index;done=false>>
   [junit4]   2> 28936 ERROR (coreCloseExecutor-12-thread-1) [    
x:collection1] o.a.s.c.CachingDirectoryFactory Error closing 
directory:org.apache.solr.common.SolrException: Timeout waiting for all 
directory ref counts to be released - gave up waiting on 
CachedDir<<refCount=1;path=/Users/amritsarkar/git_space/solr-june/lucene-solr/solr/build/solr-core/test/J0/temp/solr.update.processor.ClassificationUpdateProcessorFactoryTest_57912E1D960F4206-001/init-core-data-001/index;done=false>>
   [junit4]   2>        at 
org.apache.solr.core.CachingDirectoryFactory.close(CachingDirectoryFactory.java:177)
   [junit4]   2>        at 
org.apache.solr.core.SolrCore.close(SolrCore.java:1617)
   [junit4]   2>        at 
org.apache.solr.core.SolrCores.lambda$close$0(SolrCores.java:132)
   [junit4]   2>        at 
java.util.concurrent.FutureTask.run(FutureTask.java:266)
   [junit4]   2>        at 
org.apache.solr.common.util.ExecutorUtil$MDCAwareThreadPoolExecutor.lambda$execute$0(ExecutorUtil.java:188)
   [junit4]   2>        at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
   [junit4]   2>        at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
   [junit4]   2>        at java.lang.Thread.run(Thread.java:745)
   [junit4]   2> 
   [junit4]   2> 28936 ERROR (coreCloseExecutor-12-thread-1) [    
x:collection1] o.a.s.c.SolrCore java.lang.AssertionError: 1
   [junit4]   2>        at 
org.apache.solr.core.CachingDirectoryFactory.close(CachingDirectoryFactory.java:191)
   [junit4]   2>        at 
org.apache.solr.core.SolrCore.close(SolrCore.java:1617)
   [junit4]   2>        at 
org.apache.solr.core.SolrCores.lambda$close$0(SolrCores.java:132)
   [junit4]   2>        at 
java.util.concurrent.FutureTask.run(FutureTask.java:266)
   [junit4]   2>        at 
org.apache.solr.common.util.ExecutorUtil$MDCAwareThreadPoolExecutor.lambda$execute$0(ExecutorUtil.java:188)
   [junit4]   2>        at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
   [junit4]   2>        at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
   [junit4]   2>        at java.lang.Thread.run(Thread.java:745)
   [junit4]   2> 
   [junit4]   2> 28937 ERROR (coreCloseExecutor-12-thread-1) [    
x:collection1] o.a.s.c.SolrCores Error shutting down 
core:java.lang.AssertionError: 1
   [junit4]   2>        at 
org.apache.solr.core.CachingDirectoryFactory.close(CachingDirectoryFactory.java:191)
   [junit4]   2>        at 
org.apache.solr.core.SolrCore.close(SolrCore.java:1617)
   [junit4]   2>        at 
org.apache.solr.core.SolrCores.lambda$close$0(SolrCores.java:132)
   [junit4]   2>        at 
java.util.concurrent.FutureTask.run(FutureTask.java:266)
   [junit4]   2>        at 
org.apache.solr.common.util.ExecutorUtil$MDCAwareThreadPoolExecutor.lambda$execute$0(ExecutorUtil.java:188)
   [junit4]   2>        at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
   [junit4]   2>        at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
   [junit4]   2>        at java.lang.Thread.run(Thread.java:745)
   [junit4]   2> 
   [junit4]   2> NOTE: leaving temporary files on disk at: 
/Users/amritsarkar/git_space/solr-june/lucene-solr/solr/build/solr-core/test/J0/temp/solr.update.processor.ClassificationUpdateProcessorFactoryTest_57912E1D960F4206-001
   [junit4]   2> NOTE: test params are: codec=Asserting(Lucene70): {}, 
docValues:{}, maxPointsInLeafNode=1994, maxMBSortInHeap=5.2024544371149295, 
sim=RandomSimilarity(queryNorm=true): {}, locale=fr, 
timezone=America/Yellowknife
   [junit4]   2> NOTE: Mac OS X 10.12.5 x86_64/Oracle Corporation 1.8.0_102 
(64-bit)/cpus=4,threads=1,free=48193632,total=220200960
   [junit4]   2> NOTE: All tests run in this JVM: 
[ClassificationUpdateProcessorFactoryTest]
   [junit4] Completed [1/1 (1!)] in 30.49s, 3 tests, 1 error <<< FAILURES!
   [junit4] 
   [junit4] 
   [junit4] Tests with failures [seed: 57912E1D960F4206]:
   [junit4]   - 
org.apache.solr.update.processor.ClassificationUpdateProcessorFactoryTest.init_fullArgs_shouldInitFullClassificationParams
   [junit4] 
   [junit4] 
   [junit4] JVM J0:    15.50 ..    42.04 =    26.55s
   [junit4] Execution time total: 42 seconds
   [junit4] Tests summary: 1 suite, 3 tests, 1 error
{code}

I have posted the entire _ant 
-Dtestcase=ClassificationUpdateProcessorFactoryTest test_ log snippet.

> Make ClassificationUpdateProcessorFactory as Runtime URP; take params(s) with 
> request
> -------------------------------------------------------------------------------------
>
>                 Key: SOLR-10867
>                 URL: https://issues.apache.org/jira/browse/SOLR-10867
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: update
>            Reporter: Amrit Sarkar
>            Priority: Minor
>         Attachments: error, SOLR-10867.patch, SOLR-10867.patch, 
> SOLR-10867.patch
>
>
> We are trying to get rid of processor definitions in SolrConfig for all URPs 
> and take parameters in the request itself.
> ClassificationUpdateProcessorFactory will be able to execute by sample curl 
> like below:
> {code}
> curl -X POST -H Content-Type: application/json  
> http://localhost:8983/solr/test/update/json/docs?processor=Classification&classification.fieldName=url_s&classification.classField=training&commit=true
>  --data-binary { "id" : "1" , "url_s" : "http://www.example.com/subroot"; }
> {code}
> All the param(s) for this URP available can be passed as request handler 
> param(s).
> Configuration for ClassificationUpdateProcessorFactory in solrconfig.xml is 
> optional.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to