[
https://issues.apache.org/jira/browse/SOLR-10850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16047199#comment-16047199
]
Jason Gerlowski edited comment on SOLR-10850 at 6/12/17 11:13 PM:
------------------------------------------------------------------
When I filed this JIRA issue and SOLR-10851, I filed them separately as they
seemed like conceptually different problems. This ticket was about some a
specific Javadoc comment that used some outdated methods; SOLR-10851 was
focused on improving SolrClient documentation overall.
Both issues involved changes to the same lines of code/documentation though,
and the recent resolution of SOLR-10851 has resolved this issue by coincidence.
I'm going to mark this issue as closed (if I have the permissions to). If it
turns out that I don't, I would request that someone please close it for me.
was (Author: gerlowskija):
When I filed this JIRA issue and SOLR-10851, I filed them separately as they
seemed like conceptually different problems. This ticket was about some a
specific Javadoc comment that used some outdated methods; SOLR-10581 was
focused on improving SolrClient documentation overall.
Both issues involved changes to the same lines of code/documentation though,
and the recent resolution of SOLR-10581 has resolved this issue by coincidence.
I'm going to mark this issue as closed (if I have the permissions to). If it
turns out that I don't, I would request that someone please close it for me.
> HttpSolrClient Javadoc examples reference nonexistent constructors
> ------------------------------------------------------------------
>
> Key: SOLR-10850
> URL: https://issues.apache.org/jira/browse/SOLR-10850
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrJ
> Affects Versions: master (7.0)
> Reporter: Jason Gerlowski
> Priority: Minor
> Fix For: master (7.0)
>
> Attachments: SOLR-10850.patch
>
>
> A recent [JIRA|https://issues.apache.org/jira/browse/SOLR-10755] removed a
> number of deprecated constructors from the SolrClient implementations.
> In the case of {{HttpSolrClient}}, the top-level Javadocs contain
> instantiation instructions that still reference the old constructors:
> e.g.
> {code}
> /**
> * A SolrClient implementation that talks directly to a Solr server via HTTP
> *
> * There are two ways to use an HttpSolrClient:
> *
> * 1) Pass a URL to the constructor that points directly at a particular core
> * <pre>
> * SolrClient client = new
> HttpSolrClient("http://my-solr-server:8983/solr/core1";);
> * QueryResponse resp = client.query(new SolrQuery("*:*"));
> * </pre>
> * In this case, you can query the given core directly, but you cannot query
> any other
> * cores or issue CoreAdmin requests with this client.
> *
> * 2) Pass the base URL of the node to the constructor
> * <pre>
> * SolrClient client = new
> HttpSolrClient("http://my-solr-server:8983/solr";);
> * QueryResponse resp = client.query("core1", new SolrQuery("*:*"));
> * </pre>
> * In this case, you must pass the name of the required core for all queries
> and updates,
> * but you may use the same client for all cores, and for CoreAdmin requests.
> */
> {code}
> These Javadocs should be updated with examples that use the client Builder
> types.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
