[ https://issues.apache.org/jira/browse/SOLR-10778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16047259#comment-16047259 ]
Andrew Musselman commented on SOLR-10778: ----------------------------------------- On my list; anything that gets rid of excessive warnings that people ignore is good in my book. > Ant precommit task WARNINGS about unclosed resources > ---------------------------------------------------- > > Key: SOLR-10778 > URL: https://issues.apache.org/jira/browse/SOLR-10778 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: clients - java > Affects Versions: 4.6 > Reporter: Andrew Musselman > Priority: Minor > Attachments: notclosed.txt > > > During precommit we are seeing lots of warnings about resources that aren't > being closed, which could pose problems based on chat amongst the team. Log > snippet for example: > [mkdir] Created dir: > /var/folders/5p/6b46rm_94dzc5m8d4v56tds40000gp/T/ecj1165341501 > [ecj-lint] Compiling 419 source files to > /var/folders/5p/6b46rm_94dzc5m8d4v56tds40000gp/T/ecj1165341501 > [ecj-lint] ---------- > [ecj-lint] 1. WARNING in > /path/to/lucene-solr/solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttpSolrClient.java > (at line 920) > [ecj-lint] new LBHttpSolrClient(httpSolrClientBuilder, httpClient, > solrServerUrls) : > [ecj-lint] > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > [ecj-lint] Resource leak: '<unassigned Closeable value>' is never closed > [ecj-lint] ---------- > [ecj-lint] ---------- > [ecj-lint] 2. WARNING in > /path/to/lucene-solr/solr/solrj/src/java/org/apache/solr/client/solrj/impl/StreamingBinaryResponseParser.java > (at line 49) > [ecj-lint] JavaBinCodec codec = new JavaBinCodec() { > [ecj-lint] ^^^^^ > [ecj-lint] Resource leak: 'codec' is never closed > [ecj-lint] ---------- > [ecj-lint] ---------- > [ecj-lint] 3. WARNING in > /path/to/lucene-solr/solr/solrj/src/java/org/apache/solr/client/solrj/request/JavaBinUpdateRequestCodec.java > (at line 90) > [ecj-lint] JavaBinCodec codec = new JavaBinCodec(); > [ecj-lint] ^^^^^ > [ecj-lint] Resource leak: 'codec' is never closed > [ecj-lint] ---------- > [ecj-lint] 4. WARNING in > /path/to/lucene-solr/solr/solrj/src/java/org/apache/solr/client/solrj/request/JavaBinUpdateRequestCodec.java > (at line 113) > [ecj-lint] JavaBinCodec codec = new JavaBinCodec() { > [ecj-lint] ^^^^^ > [ecj-lint] Resource leak: 'codec' is never closed -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org