[
https://issues.apache.org/jira/browse/SOLR-9565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048472#comment-16048472
]
Jan Høydahl commented on SOLR-9565:
-----------------------------------
Great with added flexibility. Few comments:
* Remember that there is a difference between an URP class and an (named) URP
instance. It must be possible to instantiate the same URP several times with
different params (e.g. {{CloneFieldUpdateProcessorFactory}}).
* Instead of the magic -UpdateProcessorFactory suffix magic, can we perhaps let
all URPs be [named
SPIs|https://lucene.apache.org/core/6_6_0/core/org/apache/lucene/util/NamedSPILoader.NamedSPI.html]
like tokenfilters and codecs, and use the short-name as key, e.g.
{{processor=htmlstripfield}}?
* Why continue inventing dot-separated config options for complex stuff like
this when we are moving towards JSON elsewhere?
{{&HTMLStripField.fieldName=<some-field>&HTMLStripField.otherParam=<some-value>...}}
could instead be {code}/solr/update?processor={"name": "htmlstripfield",
"fieldName": "foo"}&processor={...}{code} or more complex example:
{code}/solr/update?processor={"name": "clonefield", "source": {"fieldRegex":
".*_price$", "exclude": ["list_price", "other"]}, "dest": "all_prices"}{code}
> Make every UpdateRequestProcessor available implicitly
> ------------------------------------------------------
>
> Key: SOLR-9565
> URL: https://issues.apache.org/jira/browse/SOLR-9565
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Noble Paul
>
> Now that we can 'construct' the URP chains through request parameters, we
> should make all the URPs available automatically. The next challenge is to
> make them read the configuration from request parameters as well
> to access {{HTMLStripFieldUpdateProcessorFactory}} the parameter could be
> {{processor=HTMLStripField}} (The UpdateProcessorFactory part is
> automatically appended )
> The next step is to make the URPs accept request parameters instead of just
> configuration parameters e.g:
> {{processor=HTMLStripField&HTMLStripField.fieldName=<some-field>}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
